lint python scripts in dev-tools #14318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These scripts are important, but have zero static analysis, type-checking, or formatting. Add simple make-based build with CI hook for this. Format check is not yet enabled, we should "make reformat" and commit the changes separately. Any failing violations are disabled, we can iteratively enable them.
|
If we are ok with it, I would want to backport these changes and cleanups to 10.x branch, too, so that things start to become easier. |
dweiss
approved these changes
Mar 1, 2025
|
I will followup with changes to iterate. mainly want to detect common mistakes as a start, then it won't be so terrifying to change or review these files |
asfgit
pushed a commit
that referenced
this pull request
Mar 1, 2025
These scripts are important, but have zero static analysis, type-checking, or formatting. Add simple make-based build with CI hook for this. Format check is not yet enabled, we should "make reformat" and commit the changes separately. Any failing violations are disabled, we can iteratively enable them.
hanbj
pushed a commit
to hanbj/lucene
that referenced
this pull request
Mar 12, 2025
These scripts are important, but have zero static analysis, type-checking, or formatting. Add simple make-based build with CI hook for this. Format check is not yet enabled, we should "make reformat" and commit the changes separately. Any failing violations are disabled, we can iteratively enable them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These scripts are important, but have zero static analysis, type-checking, or formatting.
Add simple make-based build with CI hook for this.
Format check is not yet enabled, we should "make reformat" and commit the changes separately.
Any failing violations are disabled, we can iteratively enable them.
This is similar to the hook added to luceneutil to start cleaning up the python there.